Popover styling fixes #2637
Merged
Popover styling fixes #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures the arrow border correctly switches when a tooltip flips to another side
|
Interesting, I understand how the render method is inherited, but I didn't catch this issue in Chrome because the Firefox implementation for |
SuaYoo
approved these changes
Jun 2, 2025
emma-sg
added a commit
that referenced
this pull request
Jun 4, 2025
Fixes #2636 ## Changes - Displays trials scheduled for cancellation alongside non-trials scheduled for cancellation - Adds filter for "bad states" — active orgs that have a cancelled subscription, orgs with a cancellation date in the past, and empty subscription ids currently, but could be extended as necessary - Displays scheduled-for-cancellation trials in the "trialing" filter as well - Improves display of future cancellation durations for both active subscriptions and trials - Surfaces issues where a trial cancellation was scheduled for the past but the org is still active - Swaps out `sl-tooltip`s for `btrix-popover`s in popovers with longer details - Adds correct heading levels, `tabindex`, and orientation for popovers in use here ## Follow-ups Once #2637 is merged we can ~~swap out the `sl-tooltip`s for `btrix-popover`s here~~ _done!_ & in the superadmin stats card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.tooltip__bodyselector instead of::part(body)for tooltip body from within element —::part(body)would work if targeting from outside the element, but not from inside, since we're inheritingsl-tooltip'srendermethoddata-current-placementinstead ofplacementattribute to determine which sides of the arrow should have borders, so that when a popover is flipped to another side the correct borders show up on the arrowcc @SuaYoo
Testing
Tested locally on latest Chrome, Safari, and Firefox