Skip to content

feat: Handle paused state + workflow performance improvements #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
May 29, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented May 14, 2025

Resolves #2569

Changes

  • Handles paused workflow state.
  • Adds "Copy Crawl ID" and "View Archived Item" buttons to workflow detail
  • Fixes file size not updating in workflow crawls list
  • Fixes superadmin banner showing over workflow tabs
  • Refactors workflow detail API calls to use Task to improve poll performance.
  • Fixes execution time rendering when less than a minute

Manual testing

  1. Log in as crawler
  2. Go to "Crawling"
  3. Run a workflow. Verify "Latest Crawl" updates as expected
  4. Click "Pause". Verify pause notices are shown.
  5. Click "Dismiss". Verify pause notice is hidden.
  6. Click "Resume". Verify pause notices are hidden.
  7. Go to "Crawling"
  8. Hover over running crawl status. Verify tooltip renders as expected.

Screenshots

Page Image/video
Workflow Screenshot 2025-05-14 at 3 51 19 PM
Workflow (less than 10m to resume) Screenshot 2025-05-14 at 3 06 38 PM
Workflow Screenshot 2025-05-26 at 3 14 21 PM
Workflow - Latest Crawl Screenshot 2025-05-14 at 4 37 33 PM
Workflow - Crawls Screenshot 2025-05-14 at 4 37 44 PM
Workflow List Screenshot 2025-05-22 at 10 43 08 AM

@SuaYoo SuaYoo changed the base branch from main to pause-resume May 19, 2025 18:05
@SuaYoo SuaYoo force-pushed the pause-resume--frontend-alerts branch from afcf67f to 8ed6c60 Compare May 20, 2025 21:19
@SuaYoo SuaYoo force-pushed the pause-resume--frontend-alerts branch from 8ed6c60 to 7487e61 Compare May 20, 2025 21:22
@ikreymer ikreymer force-pushed the pause-resume branch 2 times, most recently from 971531e to d14945f Compare May 21, 2025 16:09
@SuaYoo SuaYoo force-pushed the pause-resume--frontend-alerts branch from 7487e61 to 52ccd61 Compare May 21, 2025 17:13
Base automatically changed from pause-resume to main May 21, 2025 21:05
@ikreymer ikreymer force-pushed the pause-resume--frontend-alerts branch from 52ccd61 to 44dccad Compare May 21, 2025 21:09
@SuaYoo SuaYoo force-pushed the pause-resume--frontend-alerts branch from 417ac1d to b5891b3 Compare May 22, 2025 00:55
@SuaYoo SuaYoo changed the title feat: Show paused state in workflow details feat: Handle paused state + workflow performance improvements May 22, 2025
@SuaYoo SuaYoo marked this pull request as ready for review May 22, 2025 05:54
@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l May 22, 2025 05:55
@tw4l

This comment was marked as resolved.

@SuaYoo SuaYoo marked this pull request as draft May 22, 2025 16:16
@SuaYoo

This comment was marked as resolved.

@SuaYoo SuaYoo marked this pull request as ready for review May 22, 2025 19:23
@ikreymer

This comment was marked as resolved.

@SuaYoo

This comment was marked as resolved.

@SuaYoo SuaYoo marked this pull request as draft May 27, 2025 18:42
@SuaYoo SuaYoo marked this pull request as ready for review May 27, 2025 22:47
@SuaYoo
Copy link
Member Author

SuaYoo commented May 27, 2025

Updated to update statuses and show execution time:

Screenshot 2025-05-27 at 3 28 05 PM

Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the updated execution time formatter will render <0 minutes when the duration is 0. I believe detailsRelevant needs to be taken into account when considering when to include the "<" in compactMinutes.

@emma-sg
Copy link
Member

emma-sg commented May 28, 2025

Oh, could we also remove the three dots to the left of the "More" menu? I don't think it's necessary with the caret to the right of the text.

Chatted on Discord, gonna just swap out the three dots I think?

@SuaYoo SuaYoo requested a review from emma-sg May 28, 2025 01:34
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SuaYoo SuaYoo force-pushed the pause-resume--frontend-alerts branch from b7239d1 to 757ea12 Compare May 29, 2025 01:30
@SuaYoo SuaYoo merged commit 858ae15 into main May 29, 2025
27 checks passed
@SuaYoo SuaYoo deleted the pause-resume--frontend-alerts branch May 29, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display paused status and details in workflow
4 participants