-
-
Notifications
You must be signed in to change notification settings - Fork 52
Normalize & document icon usage, and move design documents into storybook #2597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Can we split this into 2 parts? Moving design docs to storybook, and then doing a consistency pass once pause/resume is merged in? |
9170829
to
adef47c
Compare
didn't mean to leave that in the commit
adef47c
to
8088ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #2652
This PR is the result of investigating our usage of icons and colors across the app. This investigation is document in the first table “In Use (as of 2025-05-06)” on the Status Indicators page in Storybook, included as a screenshot below.
I've then consolidated these uses with the previous version of the Status Icons document that @Shrinks99 wrote into a new Intended Implementation table, as seen below.
Finally, I updated icons across the app in places that were using different icons for the same meanings. Certain places (e.g. the superadmin org list) deviate from these norms, but I think this is okay — that implementation in particular is quite information-dense, so using a wider variety of icons and colors there works.
Finally finally, I moved both design docs from the public docs page into Storybook, as these more internally-facing design docs aren't particularly useful to end users.
Changes
remark-gfm
to enable tables in MDXColorSwatch
blockScreenshots
[working on it]