feat: UX improvements to collections with single URL #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-single-url-collection
branch
from
8b91b89 to
e554735
Compare
emma-sg
reviewed
Jan 22, 2025
Comment on lines
-178
to
-182
| <btrix-badge | ||
| slot="suffix" | ||
| variant=${status < 300 ? "success" : "danger"} | ||
| >${status}</btrix-badge | ||
| > |
There was a problem hiding this comment.
Could we display the badge (or maybe just an icon with a tooltip) for non-2xx status codes? While I like that we're getting rid of it, I do think it could still be useful to highlight pages that didn't load successfully
There was a problem hiding this comment.
They're being filtered out here, do you mean keep them in and highlight as errors?
This comment was marked as resolved.
This comment was marked as resolved.
ikreymer
approved these changes
Jan 25, 2025
|
Hm, also noticed this on the list view option. Oddly, switching to the single page works fine, showing the screenshot, but switching back to the list shows the error: Not sure if its related to the changes in this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2322
Changes
Manual testing