Skip to content

fix for direct fetch timeouts #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix for direct fetch timeouts #677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e0d0b8
simple fix for direct fetch
ikreymer Sep 4, 2024
ddff465
update to use pageLoadTimeout
ikreymer Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ self.__bx_behaviors.selectMainBehavior();
try {
const { fetched, mime, ts } = await timedRun(
directFetchCapture({ url, headers: this.headers, cdp }),
FETCH_TIMEOUT_SECS,
this.params.timeout,
"Direct fetch capture attempt timed out",
logDetails,
"fetch",
Expand Down
4 changes: 3 additions & 1 deletion src/util/recorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,10 @@ export class Recorder {

// if contentLength is large or unknown, do streaming, unless its an essential resource
// in which case, need to do a full fetch either way
// don't count non-200 responses which may not have content-length
if (
(contentLen < 0 || contentLen > MAX_BROWSER_DEFAULT_FETCH_SIZE) &&
responseStatusCode === 200 &&
!this.isEssentialResource(reqresp.resourceType, mimeType)
) {
const opts: ResponseStreamAsyncFetchOptions = {
Expand Down Expand Up @@ -1030,7 +1032,7 @@ export class Recorder {
}

isEssentialResource(resourceType: string | undefined, contentType: string) {
if (["document", "stylesheet", "script"].includes(resourceType || "")) {
if (resourceType === "script" || resourceType === "stylesheet") {
return true;
}

Expand Down
Loading