Skip to content

Consider disk usage of collDir instead of default /crawls #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

benoit74
Copy link
Contributor

Fix #585

Changes:

  • compute disk usage based on crawler collDir property instead of always computing it on /crawls directory

@benoit74
Copy link
Contributor Author

@tw4l @ikreymer this is ready for review from my PoV, I don't get why there are three failing tests which seems very unrelated from my experience (but still very limited compared to yours)

@tw4l tw4l self-requested a review May 29, 2024 15:12
@tw4l
Copy link
Member

tw4l commented May 29, 2024

Thanks for this @benoit74! Looks like the tests are okay now, maybe that was just a fluke/bad run. Will plan to review this week.

Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yep, i think that makes sense! I think we set it to /crawls in case multiple crawls are running using same volume locally, but that should still work fine and allows for more granular checking

@ikreymer ikreymer merged commit 32435bf into webrecorder:main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crawler is not checking the proper disk usage
3 participants