Skip to content

Upgrade to Ubuntu Noble Numbat 24.04 LTS #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2024
Merged

Upgrade to Ubuntu Noble Numbat 24.04 LTS #20

merged 2 commits into from
Aug 15, 2024

Conversation

benoit74
Copy link
Contributor

Fix #19

Changes:

  • changed base image
  • moved from libasound2 to libasound2t64 since in noble it's a virtual package with two installation candidates, and libasound2t64 seems to be the one closest to what was used in Jammy

@benoit74
Copy link
Contributor Author

Tests:

@benoit74
Copy link
Contributor Author

This is ready for review

@benoit74
Copy link
Contributor Author

I just added python3-venv since now Debian-based systems expect you to install your dependencies in a venv to not mess with dependencies installed with official apt packages, so most users of this base image will need this venv stuff

@benoit74 benoit74 mentioned this pull request May 30, 2024
Merged
@tw4l tw4l self-requested a review May 30, 2024 13:41
@tw4l
Copy link
Member

tw4l commented May 30, 2024

We may want to time merging this with a Brave update so that we have a distinct image tag for the switch to Ubuntu 24

@benoit74
Copy link
Contributor Author

Makes sense! No hurry on my side, at least it is ready for next brave update ^^

@tw4l tw4l mentioned this pull request Jun 4, 2024
Merged
@benoit74
Copy link
Contributor Author

Looks like you've updated Brave but forgotten to also upgrade Ubuntu :(

Or was it an automated update of Brave ?

@ikreymer
Copy link
Member

We are moving to browsertrix crawler 1.3.0, so this should be good to merge finally!

re: python3 removal, even though we do plan to remove dependencies on python3, testing this build w/o python3* packages result in an image that's just 60MB smaller - (2.14GB vs 2.2GB), so it is negligible, so can keep this is in for now/maybe always (since zimit will need to re-add python).

@ikreymer ikreymer merged commit 8738030 into webrecorder:main Aug 15, 2024
ikreymer added a commit to webrecorder/browsertrix-crawler that referenced this pull request Aug 15, 2024
@benoit74 @tw4l @ikreymer
Update Brave image + isolated Python venv for dependencies installati…
4cc67a3 
…on (#591)

- Debian distro now requires the use of virtual environments to not mess
with dependencies installed by official apt packages
- removes tldextract update now that pywb is not in use anymore
- bump brave version to 1.68.141, for use with base image added in
webrecorder/browsertrix-browser-base#20

---------
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Co-authored-by: Ilya Kreymer <ikreymer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade from ubuntu:jammy to ubuntu:noble
3 participants
@benoit74 @tw4l @ikreymer