-
-
Notifications
You must be signed in to change notification settings - Fork 496
feat: Brotli compression support #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
documentation-driven development For now, we accept potential inconsistencies between `compressionAlgorithm` and `defaultSizes`. Consolidating the compression API is left for a later major release. See discussions: * https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/432/files#r613949751 * https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/432/files#r614300494
c358d1e
to
b4c4b33
Compare
Thanks! I'll take a closer look when possible, right now I'm pressed on time |
As long as we can make it within the next four years, we'd still beat #432. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, great work here! I'll still take this for a spin when I can to test it out.
Could you add a changelog entry as a new feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This seems to work nicely 👍
Cleanup after webpack-contrib#663
Reimplemented #432 including feedback.
Based on
master
before #650 (see #650 (comment)) to allow for local testing.gzip-size
can be uninstalled. I did not include this commit b/c it creates a conflict with changes onmaster
after my base.