Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

fix: remove force exit from web3-eth tests #7398

Closed
wants to merge 2 commits into from
Closed

fix: remove force exit from web3-eth tests #7398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c820198
fix: remove force exit from web3-eth tests
krzysu Nov 18, 2024
28a8c47
trigger network tests
krzysu Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ on:
- '4.x'
tags:
- v4*
pull_request:
branches:
- '4.x'
types: [opened, reopened, synchronize]
# pull_request:
# branches:
# - '4.x'
# types: [opened, reopened, synchronize]

jobs:
build:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/e2e_network_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ on:
tags:
- v4.*

# For test purpose only:
# pull_request:
# branches:
# - '4.x'
# types: [ opened, reopened, synchronize ]
pull_request:
branches:
- '4.x'
types: [opened, reopened, synchronize]

jobs:
build:
name: Build Packages
Expand Down
6 changes: 3 additions & 3 deletions packages/web3-eth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@
"test": "jest --config=./test/unit/jest.config.js",
"test:coverage:unit": "jest --config=./test/unit/jest.config.js --coverage=true --coverage-reporters=text",
"test:ci": "jest --coverage=true --coverage-reporters=json --verbose",
"test:e2e:mainnet": "jest --config=./test/e2e/jest.config.js --forceExit",
"test:e2e:sepolia": "jest --config=./test/e2e/jest.config.js --forceExit",
"test:e2e:mainnet": "jest --config=./test/e2e/jest.config.js",
"test:e2e:sepolia": "jest --config=./test/e2e/jest.config.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luu-alex @jdevcs these tests from web3-eth package seems to be always skipped, even in the release builds, maybe we should just delete them altogether? ie. see https://github.com/web3/web3.js/actions/runs/11710089473/job/32616617212

> web3-eth:"test:e2e:sepolia"

$ jest --config=./test/e2e/jest.config.js --forceExit

Test Suites: 1 skipped, 0 of 1 total
Tests:       1 skipped, 1 total

"test:watch": "npm test -- --watch",
"test:unit": "jest --config=./test/unit/jest.config.js",
"test:integration": "jest --config=./test/integration/jest.config.js --runInBand",
"test:coverage:integration": "jest --config=./test/integration/jest.config.js --runInBand --forceExit --coverage=true --coverage-reporters=text",
"test:coverage:integration": "jest --config=./test/integration/jest.config.js --runInBand --coverage=true --coverage-reporters=text",
"test:e2e:electron": "npx cypress run --headless --browser electron",
"test:e2e:chrome": "npx cypress run --headless --browser chrome",
"test:e2e:firefox": "npx cypress run --headless --browser firefox"
Expand Down
Loading