Skip to content

Allow psr/cache v2 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Allow psr/cache v2 #620

merged 2 commits into from
May 7, 2025

Conversation

jdreesen
Copy link

@jdreesen jdreesen commented May 6, 2025

Target branch: 3.4.x

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

Allow psr/cache v2 to be compatible with symfony/cache ^5.4 which only allows psr/cache ^1.0|^2.0 (see: https://github.com/symfony/cache/blob/5.4/composer.json#L25)

@jdreesen
Copy link
Author

jdreesen commented May 6, 2025

Pipeline failures don't seem to be related 🤔

@Spomky Spomky added this to the 3.3.6 milestone May 7, 2025
@Spomky Spomky added the Dependencies Pull requests that update a dependency file label May 7, 2025
@Spomky
Copy link
Member

Spomky commented May 7, 2025

Pipeline failures don't seem to be related 🤔

No worries about the failing pipeline.
Could you please target 3.3.x and rebase? I will tag as 3.3.6 instead of 3.4.0 as there is no new feature.

@jdreesen
Copy link
Author

jdreesen commented May 7, 2025

But the PR that added psr/cache as a dependency (#550) was released as 3.4.0. So I would have expected 3.4.8 to be the next version with this fix 🤔

@Spomky Spomky modified the milestones: 3.3.6, 3.4.8 May 7, 2025
@Spomky
Copy link
Member

Spomky commented May 7, 2025

Indeed 😅. So let merge and tag.

@Spomky Spomky merged commit 7882670 into web-token:3.4.x May 7, 2025
9 of 13 checks passed
@jdreesen jdreesen deleted the patch-1 branch May 7, 2025 09:34
@jdreesen
Copy link
Author

jdreesen commented May 7, 2025

@Spomky it seems like the gitsplit action didn't run, so the https://github.com/web-token/jwt-library repo wasn't updated and the new 3.4.8 tag doesn't show up in https://packagist.org/packages/web-token/jwt-library, which means I cannot use it.

Can you please have a look?

@Spomky
Copy link
Member

Spomky commented May 7, 2025

I manually split the branch. This should be fixed now.

@jdreesen
Copy link
Author

jdreesen commented May 7, 2025

Great, now it is available. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants