-
-
Notifications
You must be signed in to change notification settings - Fork 759
fix: resolveData.*_dependencies should work when factorize success #10967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
📦 Binary Size-limit
🎉 Size decreased by 121.25KB from 57.57MB to 57.45MB (⬇️0.21%) |
CodSpeed Performance ReportMerging #10967 will improve performances by 75.06%Comparing 🎉 Hooray!
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
⚡ | bundle@basic-react-development |
8.9 ms | 5.1 ms | +75.06% |
08d209d
to
46cdb48
Compare
📝 Benchmark detail: Open
Threshold exceeded: ["10000_production-mode_persistent-hot + exec","large-dyn-imports_development-mode + exec"] |
I'm ok with this if the |
This PR will result in
|
Summary
Rspack will lose dependency factorize info include file_dependencies, missing_dependencies when it factorize success,
this behaivor will make the file_dependencies added by user at
normalModuleFactory.hooks.resolve
useless.This PR will make dependency rebuilds behave more like modules, and the dependency will refactorize if modifed files in its factorize_info.file_dependencies.
Related links
Checklist