[Feature]: Sync with latest binding.js from napi-rs to fix performance issue #10963
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the binding.js files with the latest napi-rs template to fix a performance issue where
process.report.getReport()
was taking up to 5 seconds on some systems due to network information collection.Problem
The
isMusl()
function in our binding files was callingprocess.report.getReport()
without excluding network information, which caused severe performance degradation on certain systems (particularly those with specific network configurations). This resulted in 5+ second delays during binding initialization, as reported in #9798.Solution
Following the fix implemented in napi-rs, we now set
process.report.excludeNetwork = true
before callingprocess.report.getReport()
. This excludes network-related information from the report generation, significantly improving performance while maintaining the same functionality for libc detection.Changes
Updated the
isMusl()
function in three files:crates/node_binding/binding.js
crates/rspack_binding_builder_testing/binding.js
packages/rspack/src/util/bindingVersionCheck.ts
Before:
After:
Performance Impact
Testing
process.report.excludeNetwork
is properly setFixes #10694.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.