Skip to content

refactor: remove the encapsulation for rspack_fs::Error #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

refactor: remove the encapsulation for rspack_fs::Error #10942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd2fe43
Add test-wasm for test wasm locally
CPunisher Jul 7, 2025
8483d0f
Remove unnecessary rspack_fs Error
CPunisher Jul 8, 2025
4e412b8
Fix clippy
CPunisher Jul 8, 2025
c1e9dfe
Fix clippy
CPunisher Jul 8, 2025
8ea7d95
Add upload artifact
CPunisher Jul 8, 2025
d9d613e
Revert "Fix clippy"
CPunisher Jul 8, 2025
ce19e8a
Revert "Fix clippy"
CPunisher Jul 8, 2025
c062dc6
Revert "Remove unnecessary rspack_fs Error"
CPunisher Jul 8, 2025
c9804a3
Debug
CPunisher Jul 8, 2025
7e4147c
Debug
CPunisher Jul 8, 2025
ec2e044
Debug
CPunisher Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions .github/workflows/size-limit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,26 @@ jobs:
with:
tool-cache: fals

- name: Build x86_64-unknown-linux-gnu native
run: |
unset CC_x86_64_unknown_linux_gnu && unset CC # for jemallocator to compile
rustup target add x86_64-unknown-linux-gnu
RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:release
# - name: Build x86_64-unknown-linux-gnu native
# run: |
# unset CC_x86_64_unknown_linux_gnu && unset CC # for jemallocator to compile
# rustup target add x86_64-unknown-linux-gnu
# RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:profiling

- name: Binary Size-limit
uses: ./.github/actions/binary-limit
with:
# 50k 50*1024
size-threshold: 51200
# - name: Upload artifact
# uses: ./.github/actions/artifact/upload
# with:
# name: bindings-${{ inputs.target }}
# path: |
# crates/node_binding/*.node

# - name: Binary Size-limit
# uses: ./.github/actions/binary-limit
# with:
# # 50k 50*1024
# size-threshold: 51200

- name: Debug
uses: ./.github/actions/debugger
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions packages/rspack-test-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"dev": "tsc -b -w",
"test": "cross-env RUST_BACKTRACE=full pnpm run --stream /^test:.*/",
"testu": "pnpm run --stream /^test:.*/ -u",
"test-wasm": "cross-env NAPI_RS_FORCE_WASI=1 WASM=1 NODE_NO_WARNINGS=1 pnpm run test",
"test:base": "cross-env node --no-warnings --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --colors --config ./jest.config.js --passWithNoTests",
"test:hot": "cross-env RSPACK_HOT_TEST=true node --no-warnings --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --colors --config ./jest.config.hot.js --passWithNoTests",
"test:diff": "cross-env RSPACK_DIFF=true node --no-warnings --expose-gc --max-old-space-size=8192 --experimental-vm-modules ../../node_modules/jest-cli/bin/jest --logHeapUsage --colors --config ./jest.config.diff.js --passWithNoTests",
Expand Down
Loading