Skip to content

perf: override wasmer-wasix to remove all unused wasi extension feature #10885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Jul 3, 2025

Summary

override wasmer-wasix to remove all unused wasi extension to reduce binary size

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3000f9f
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/686b3b980d89e5000816c76d

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

📦 Binary Size-limit

Comparing binary size with Commit: chore: release v1.4.4 (#10917) by neverland

🎉 Size decreased by 896bytes from 59.95MB to 59.95MB (⬇️0.00%)

Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Performance Report

Merging #10885 will not alter performance

Comparing yj/remove-wasmer-wasix-feature (3000f9f) with main (6cddb40)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@hardfist hardfist marked this pull request as draft July 3, 2025 05:00
@syrusakbary
Copy link

Hey! If you open a PR to Wasmer upstream, we would be happy to have it there, so you don't need to fork.
Note: we would need this to be feature gated.

Thanks!

@hardfist
Copy link
Contributor Author

hardfist commented Jul 7, 2025

Hey! If you open a PR to Wasmer upstream, we would be happy to have it there, so you don't need to fork. Note: we would need this to be feature gated.

Thanks!

@syrusakbary Thanks, this pr is actually used to verify how much binary reduction we can get if remove unused wasix feature, no intention to bifurcate, I will make a PR soon.

@hardfist
Copy link
Contributor Author

hardfist commented Jul 7, 2025

@syrusakbary I'm not sure whether I should make sys feature empty or add another feature like wasi-common which contains only minimal wasi feature

@hardfist hardfist force-pushed the yj/remove-wasmer-wasix-feature branch from 65eb28b to 46018e3 Compare July 7, 2025 03:12
@hardfist hardfist force-pushed the yj/remove-wasmer-wasix-feature branch from 46018e3 to 3000f9f Compare July 7, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants