Skip to content

perf: parallel find new name in concatenated code generation #10874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jul 2, 2025

Summary

This PR should not be merged before full discussion

Parallel finding names of concatenated modules. Using module index to make sure that the names will not conflict.

Before:
image

After:
image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2ee9f55
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6864ff34496b3d0008731252

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 2, 2025
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #10874 will not alter performance

Comparing perf/parallel-find-new-name (2ee9f55) with main (1161892)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jul 2, 2025

📝 Benchmark detail: Open

Name Base (2025-07-02 99bc1d2) Current Change
10000_big_production-mode_disable-minimize + exec 33.8 s ± 628 ms 35.3 s ± 365 ms +4.25 %
10000_development-mode + exec 1.9 s ± 21 ms 1.86 s ± 30 ms -2.05 %
10000_development-mode_hmr + exec 704 ms ± 12 ms 686 ms ± 19 ms -2.56 %
10000_production-mode + exec 1.94 s ± 22 ms 1.92 s ± 130 ms -0.92 %
10000_production-mode_persistent-cold + exec 2.11 s ± 133 ms 2.05 s ± 37 ms -3.22 %
10000_production-mode_persistent-hot + exec 1.49 s ± 26 ms 1.49 s ± 36 ms +0.04 %
arco-pro_development-mode + exec 1.79 s ± 89 ms 1.85 s ± 82 ms +3.59 %
arco-pro_development-mode_hmr + exec 372 ms ± 0.93 ms 371 ms ± 2.1 ms -0.24 %
arco-pro_production-mode + exec 3.29 s ± 79 ms 3.32 s ± 46 ms +1.09 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.4 s ± 109 ms 3.43 s ± 202 ms +0.93 %
arco-pro_production-mode_persistent-cold + exec 3.39 s ± 108 ms 3.43 s ± 152 ms +1.20 %
arco-pro_production-mode_persistent-hot + exec 2.11 s ± 74 ms 2.1 s ± 58 ms -0.63 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.32 s ± 152 ms 3.42 s ± 164 ms +3.16 %
large-dyn-imports_development-mode + exec 2.11 s ± 50 ms 2.08 s ± 27 ms -1.43 %
large-dyn-imports_production-mode + exec 2.07 s ± 17 ms 2.08 s ± 41 ms +0.96 %
threejs_development-mode_10x + exec 1.45 s ± 6 ms 1.48 s ± 91 ms +1.82 %
threejs_development-mode_10x_hmr + exec 845 ms ± 19 ms 823 ms ± 17 ms -2.59 %
threejs_production-mode_10x + exec 4.6 s ± 75 ms 4.65 s ± 95 ms +0.91 %
threejs_production-mode_10x_persistent-cold + exec 4.71 s ± 87 ms 4.81 s ± 290 ms +2.12 %
threejs_production-mode_10x_persistent-hot + exec 4.19 s ± 254 ms 4.19 s ± 56 ms +0.05 %
10000_big_production-mode_disable-minimize + rss memory 9593 MiB ± 44.4 MiB 9622 MiB ± 43.1 MiB +0.31 %
10000_development-mode + rss memory 687 MiB ± 19.9 MiB 725 MiB ± 21 MiB +5.59 %
10000_development-mode_hmr + rss memory 827 MiB ± 33.1 MiB 851 MiB ± 30 MiB +2.92 %
10000_production-mode + rss memory 636 MiB ± 49.9 MiB 682 MiB ± 62.6 MiB +7.20 %
10000_production-mode_persistent-cold + rss memory 758 MiB ± 19.2 MiB 815 MiB ± 58.9 MiB +7.46 %
10000_production-mode_persistent-hot + rss memory 747 MiB ± 25.8 MiB 770 MiB ± 46.1 MiB +3.14 %
arco-pro_development-mode + rss memory 598 MiB ± 71.7 MiB 609 MiB ± 57.6 MiB +1.87 %
arco-pro_development-mode_hmr + rss memory 496 MiB ± 13.6 MiB 532 MiB ± 23.7 MiB +7.30 %
arco-pro_production-mode + rss memory 673 MiB ± 39.1 MiB 706 MiB ± 31.2 MiB +4.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 697 MiB ± 84.7 MiB 707 MiB ± 45.8 MiB +1.48 %
arco-pro_production-mode_persistent-cold + rss memory 819 MiB ± 95.1 MiB 809 MiB ± 46.4 MiB -1.20 %
arco-pro_production-mode_persistent-hot + rss memory 673 MiB ± 38.2 MiB 700 MiB ± 31.7 MiB +4.03 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 660 MiB ± 58.9 MiB 713 MiB ± 77.3 MiB +8.16 %
large-dyn-imports_development-mode + rss memory 697 MiB ± 3.21 MiB 725 MiB ± 16.2 MiB +3.96 %
large-dyn-imports_production-mode + rss memory 589 MiB ± 3.87 MiB 637 MiB ± 9.61 MiB +8.12 %
threejs_development-mode_10x + rss memory 615 MiB ± 14.1 MiB 649 MiB ± 11.6 MiB +5.54 %
threejs_development-mode_10x_hmr + rss memory 808 MiB ± 26.5 MiB 811 MiB ± 16 MiB +0.33 %
threejs_production-mode_10x + rss memory 838 MiB ± 165 MiB 826 MiB ± 175 MiB -1.47 %
threejs_production-mode_10x_persistent-cold + rss memory 821 MiB ± 15.5 MiB 854 MiB ± 27.1 MiB +4.04 %
threejs_production-mode_10x_persistent-hot + rss memory 704 MiB ± 45.4 MiB 730 MiB ± 45.3 MiB +3.74 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant