Skip to content

fix(rstest): bugs #10844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix(rstest): bugs #10844

merged 1 commit into from
Jul 14, 2025

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Jun 30, 2025

Summary

  • unify runtime module prefix with rstest_.
  • handle rstest the same way as rs.
  • add rs.hoisted method, which will only perform hoisting process
  • use to_string of Utf8PathBuf to handle both ./ and ../ case in path
  • handle static import order conflicts with hoisting. (not fully resolved, partial resolved by using StageESMImports)
    image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 25ce90b
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/686cf6985d22b700087675a0

@fi3ework fi3ework marked this pull request as draft June 30, 2025 11:09
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 30, 2025
Copy link

codspeed-hq bot commented Jun 30, 2025

CodSpeed Performance Report

Merging #10844 will not alter performance

Comparing rstest-bugs (25ce90b) with main (015be6e)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jul 8, 2025

📦 Binary Size-limit

Comparing 25ce90b to fix(binding-builder): pre-generate workspace info (#10948) by Hana

❌ Size increased by 1.13KB from 59.50MB to 59.50MB (⬆️0.00%)

@fi3ework fi3ework marked this pull request as ready for review July 8, 2025 11:59
@fi3ework fi3ework requested a review from LingyuCoder as a code owner July 8, 2025 11:59
@fi3ework fi3ework merged commit 84e403a into main Jul 14, 2025
76 of 78 checks passed
@fi3ework fi3ework deleted the rstest-bugs branch July 14, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants