Skip to content

Conversation

wcandillon
Copy link
Owner

No description provided.

@wcandillon wcandillon requested a review from Copilot September 11, 2025 18:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes dependency cycles in C++ header files to improve compilation and prevent circular include issues. The changes involve converting static functions to inline functions in unions header file and reordering includes to break circular dependencies.

  • Convert static functions to inline functions in Unions.h to enable header-only implementation
  • Reorder includes to break circular dependencies between headers
  • Add forward declarations where needed to prevent circular includes

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/webgpu/cpp/rnwgpu/api/descriptors/Unions.h Convert all static function declarations to inline to enable header-only usage
packages/webgpu/cpp/rnwgpu/api/GPURenderPassEncoder.cpp Reorder includes to place Convertors.h before GPURenderPassEncoder.h
packages/webgpu/cpp/rnwgpu/api/GPUError.h Reorder standard library includes alphabetically
packages/webgpu/cpp/rnwgpu/api/Convertors.h Add include for Unions.h header
packages/webgpu/cpp/jsi/RNFJSIConverter.h Remove circular include and add Unions.h include
packages/webgpu/cpp/jsi/RNFHybridObject.h Replace direct include with forward declaration and move include after

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wcandillon wcandillon requested a review from Copilot September 11, 2025 18:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wcandillon
Copy link
Owner Author

@copilot can you approve the PR?

@wcandillon wcandillon merged commit 98612f6 into main Sep 11, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant