Fabric custom shadow node for Android #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act-native-webgpu into android-custom-shadow-node
…act-native-webgpu into android-custom-shadow-node
|
@piaskowyk I am closing this in favor of #137 but let's keep refine this and build the best Canvas API in React Native 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the default shadow nodes generated by Fabric with custom ones to obtain information about component size before the native component is mounted. This will enable us to access information about the canvas size inside the
useEffect().While we have successfully implemented this for iOS, for Android, I need to commit the files generated by the codegen to override the layout method since there is no available method
componentDescriptorProviderlike on iOS.The StaticDataBridge library is utilized to transfer data between the Shadow Node and JNI module (cpp-adapter.cpp). This process is tricky because both files are compiled by different CMakeFiles.
This PR introduces lazy initialization of the View on Android. If the native surface isn't ready, it will produce an off-screen texture buffer, and once the surface is ready, the previously created texture will be pushed to the native surface.