Removal of Dependencies to Libraries Before Migration #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioDonda
changed the title
LucioDonda
changed the title
LucioDonda
changed the title
cborla
reviewed
Sep 19, 2024
LucioDonda
changed the title
LucioDonda
force-pushed
the
poc/152-os-regex-removal
branch
from
5c86736 to
966e8cc
Compare
LucioDonda
force-pushed
the
poc/152-os-regex-removal
branch
from
966e8cc to
10ae0e9
Compare
LucioDonda
merged commit b8fe691
into
enhancement/17-migrate-syscollector-to-inventory-at-new-agent
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although the base idea was to replace the regex library with re2 as stated on the base issue, we have proceded with a first removal of any reference of this specially related to inventory which is the parent development.
Hypothesis
Because we're dealing with a great amount of legacy code that we don't really want to keep using we have decided to first cut any relation with the os_regex library.
Proposal
Tests