Remove GHC repetitions from Github actions #3241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
commented
Oct 9, 2025
| The version of Cabal to install. | ||
| required: false | ||
| default: "latest" | ||
| default: "3.10.2.0" |
There was a problem hiding this comment.
Better to pin down cabal too.
There was a problem hiding this comment.
Yeah always better to pin down stuff. Although cabal specifically is mostly ok to always use the newest version. But one day breaking change will come, so why not pin down :).
sodic
commented
Oct 9, 2025
There was a problem hiding this comment.
This is now the only file that lists both versions. We get much less repetition at the cost of some flexibility (e.g., we can no longer dispatch or call waspc-build with a different compiler version.
Is this important to us @cprecioso?
Merged
FranjoMindek
reviewed
Oct 9, 2025
Martinsos
approved these changes
Oct 9, 2025
cprecioso
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of places where we explicitly list our GHC/Cabal version by relying on the defualt versions in the
setup-haskellaction.