Skip to content

Conversation

FranjoMindek
Copy link
Contributor

@FranjoMindek FranjoMindek commented Sep 29, 2025

Fixes #3085

The goal is to make todoApp more public and accessible to users.
For that reason we are renaming it to kitchen-sink and moving it to examples/ (from waspc/examples/) dir.

As such kitchen-sink becomes one of our example apps and will be treated so.

To go along with that, we are moving kitchen-sink tests from waspc-ci.yaml workflow to examples-e2e-tests.yaml.
Additionally, we are adding it as one of the deploy-examples.yml options.

NOTE:
This will currently make it so we don't run kitchen-sink tests on each PR.
HOWEVER, in our release post mortem we did declare that we will want to run examples-e2e-tests.yaml (along with other test worklows) on each PR. So when we do remove paths from their PR triggers, this will go back to old behavior of running kitchen-sink tests on each PR.

In this PR I also:

  • update the kitchen-sink's README.md
  • remove the ensure_app_compiles_and_builds.sh script
    • we don't lose anything, it was wasp build + tsc
  • update the run script
    • test:examples now includes kitchen-sink
    • there is still specific test:kitchen-sink
    • I've added npx playwright install --with-deps to playwright based tests to make sure we have all the deps installed

Sidenote: It's really hard to check if I covered all todoApp renames since our tutorial apps are also called todoApp. It's good that we are renaming because confusion.

TODO: Generate kitchen-sink production API keys.

Copy link

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: 298cc3c
Status: ✅  Deploy successful!
Preview URL: https://6c463e2c.wasp-docs-on-main.pages.dev
Branch Preview URL: https://franjo-todoapp-renaming.wasp-docs-on-main.pages.dev

View logs

@infomiho infomiho self-requested a review October 1, 2025 11:54
@Martinsos
Copy link
Member

Nice stuff! I will let @infomiho approve since he knows this part better, but I support the change, and PR description sounds reasonable to me, so soft approve from me :D.

Copy link
Contributor

@infomiho infomiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense and the changes look OK to me.

I'd say we are blocked by:

This will currently make it so we don't run kitchen-sink tests on each PR.

I'd merge this only AFTER we implement the change that will run example apps tests on each PR, so we are not in a limbo with PRs that are not running tests on the kitchen-sink app.

Let me know if you need help with generating any of the production API keys for the kitchen sink app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The name and location of waspc/examples/todoApp

3 participants