-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Rename todoApp
to kitchen-sink
and move it to examples/
dir
#3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying wasp-docs-on-main with
|
Latest commit: |
298cc3c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6c463e2c.wasp-docs-on-main.pages.dev |
Branch Preview URL: | https://franjo-todoapp-renaming.wasp-docs-on-main.pages.dev |
Nice stuff! I will let @infomiho approve since he knows this part better, but I support the change, and PR description sounds reasonable to me, so soft approve from me :D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense and the changes look OK to me.
I'd say we are blocked by:
This will currently make it so we don't run kitchen-sink tests on each PR.
I'd merge this only AFTER we implement the change that will run example apps tests on each PR, so we are not in a limbo with PRs that are not running tests on the kitchen-sink app.
Let me know if you need help with generating any of the production API keys for the kitchen sink app.
Fixes #3085
The goal is to make
todoApp
more public and accessible to users.For that reason we are renaming it to
kitchen-sink
and moving it toexamples/
(fromwaspc/examples/
) dir.As such
kitchen-sink
becomes one of our example apps and will be treated so.To go along with that, we are moving
kitchen-sink
tests fromwaspc-ci.yaml
workflow toexamples-e2e-tests.yaml
.Additionally, we are adding it as one of the
deploy-examples.yml
options.NOTE:
This will currently make it so we don't run
kitchen-sink
tests on each PR.HOWEVER, in our release post mortem we did declare that we will want to run
examples-e2e-tests.yaml
(along with other test worklows) on each PR. So when we do removepaths
from their PR triggers, this will go back to old behavior of runningkitchen-sink
tests on each PR.In this PR I also:
kitchen-sink
'sREADME.md
ensure_app_compiles_and_builds.sh
scriptwasp build
+tsc
run
scripttest:examples
now includeskitchen-sink
test:kitchen-sink
npx playwright install --with-deps
toplaywright
based tests to make sure we have all the deps installedSidenote: It's really hard to check if I covered all
todoApp
renames since our tutorial apps are also calledtodoApp
. It's good that we are renaming because confusion.TODO: Generate
kitchen-sink
production API keys.