Correctly set dir to serve in wasp-app-runner #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
reviewed
Sep 18, 2025
wasp-app-runner/src/build/client.ts
Outdated
Comment on lines
70
to
73
| args: ["serve", "--single", "-p", "3000"], | ||
| cwd: path.join(pathToApp, clientAppBuildOutputDir), | ||
| args: ["serve", "--single", "-p", "3000", servePath], | ||
| cwd: servePath, |
There was a problem hiding this comment.
Can we replace npx serve with npm run preview since this is what you ended up doing in wasp start build? (even better, we just call wasp start build in the future)?
There was a problem hiding this comment.
It would be npm run preview -- --port 3000 --strictPort I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made as part of
There is an interaction when running
npxin an inner folder of subpackage in an npm workspace:my-project/package.json(hasworkspaces: ["sub-project"])sub-project/package.jsonbuild/index.htmlDoing the following:
cd sub-project/build npx serveWill call
servewith thecwdset tosub-projectand notbuild.npxdetects it's in aworkspaceenvironment, and then works extra hard to find the current package root, and run the program there (same as if you were doingnpm run build, which runs in the package root). But in this case it will serve an incorrect directory.To adapt ourselves to the new behaviour, we explicitly tell
npx servethe location of the folder we want it to run.I send this PR ahead of time because the
wasp-app-runnerused for E2E examples is taken fromnpm, so we should do this change first and then publish so that #3159 can pass the tests. (I made an issue at #3169 to address that at some point)