Modernize e2e-tests
#3114
Merged
Modernize e2e-tests
#3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranjoMindek
commented
Sep 4, 2025
This reverts commit c1d586b.
FranjoMindek
commented
Sep 5, 2025
FranjoMindek
commented
Sep 5, 2025
Martinsos
reviewed
Sep 5, 2025
# Conflicts: # waspc/e2e-test/GoldenTests/WaspBuildGoldenTest.hs # waspc/e2e-test/GoldenTests/WaspCompileGoldenTest.hs # waspc/e2e-test/Tests/WaspBuildTest.hs # waspc/e2e-test/Tests/WaspCompileTest.hs # waspc/e2e-tests/Common.hs # waspc/e2e-tests/Tests/WaspBuildTest.hs # waspc/e2e-tests/Tests/WaspCompileTest.hs # waspc/e2e-tests/Tests/WaspComplexTest.hs # waspc/e2e-tests/Tests/WaspJobTest.hs # waspc/e2e-tests/Tests/WaspMigrateTest.hs # waspc/e2e-tests/Tests/WaspNewTest.hs
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Error
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
# Conflicts: # waspc/e2e-tests/test-outputs/waspComplexTest-golden/waspComplexTest/main.wasp # waspc/e2e-tests/test-outputs/waspJob-golden/waspJob/main.wasp
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Error
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
FranjoMindek
had a problem deploying
to
fly-deploy-test
GitHub Actions
Error
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to refactor
waspc/e2e-teststo make the whole project more understandable, easier to use and up to date with current Wasp project. This PR wont try to expande2e-testswith additional tests.How this is achieved:
waspComplexsnapshot test withkitchen-sinksnapshot tests. Instead of creating our own complex Wasp application for testing purposes, we use the existingkitchen-sink(oldtodoApp) Wasp app. (simplification)e2e-tests/README.mdAlong the way we also expanded upon old logic to make it easier to reason when can specific shell commands be executed. Or more specifically in which context.
This is done by splitting the old
ShellCommandContextinto:WaspAppContextSnapshotTestContextWhere each context assumes in which environment their commands are run.
This change was also followed by project structure change, where context specific commands exist in their separate folders:
ShellCommands.hs,SnapshotTest/ShellCommands.hs,WaspApp/ShellCommands.hs.Part of: #1963