-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(vite-devtools): automatic Chrome DevTools workspace mapping #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the investigation and the implementation 🙏🙏🙏, I hope it wasn't too hard, and that it was fun too!
I have some minor style nitpicks, but I can bring those up later. First, I have two major questions, can you take a look?
@0xTaneja I think the improvements you made to the plugin are super nice! Other users of the plugin will also probably want to have them. And we'd prefer to just use the plugin as a dependency if it's so similar. So this is what I would do:
Moreover, I'd like to scrap the environment variable approach, it feels like a way too wide solution for the problem we have. I'd prefer to write that variable into the What do you think? Is this plan nice for you? You'll also get twice the open source contributions from this 🤘 |
@cprecioso the plan sounds perfect !! let's tag team and win this !! |
okay i will start editing vite config template and data associated with it |
oh @0xTaneja I meant to communicate that this is what you should do! this way the contirbutions are on your name! |
@cprecioso understood captain !! will be doing this !! |
@cprecioso, first part is done, pr got merged for chrome devtools, now i can focus on second part of directly using the plugin as a dependency in our Vite config, |
56b9a8d
to
2f20528
Compare
2f20528
to
ec1f3be
Compare
@0xTaneja I see you're working on this, ping me when you're done so I can review! |
@cprecioso it was already done , just forgot to add a demo video to the pr 2025-07-23.00-22-28.mp4 |
@cprecioso have you reviewed it ?? well earlier there were no conflicts but i guess after wasp new version release getting those !! will resolve it |
Hey @0xTaneja, it's on my to-do list for this week, I'll ping you when I'm done 🙏 |
Hi @0xTaneja, First, thank you so much for this contribution and the effort you put into getting the upstream changes merged! We truly appreciate it. After an internal discussion, we've been weighing the benefit of adding this feature by default for all users against our goal of keeping the default Wasp setup as lean as possible. However, we think this is a fantastic feature that would be perfect as a guide in our documentation! It would allow users who want this functionality to easily opt-in. Would you be open to closing this PR and instead adding a short guide to the docs explaining how a user can add this feature themselves (e.g. in the Custom Vite Config section)? Your work is useful for the larger Vite community, and it would still be a huge and valuable contribution to the Wasp community. Let us know what you think! Thanks again for your excellent work. |
@cprecioso yep captain !! i am ready to do anything for wasp community !! once this issue was started !! we worked together , though i did codes, but your guidance has always made me rethink !! and yeah i felt adding a docs about having this feature before closing it ! and i was going to add it but was just waiting for you to complete your review !! if you have any other review's as well , feel free to comment otherwise I'd be prepping up to close this issue |
Hey @0xTaneja, we love your enthusiasm! 🤩🐝 I realize my previous comment wasn't clear: my suggestion is to not merge the code changes from this PR. Instead, create a new documentation-only PR to share your knowledge in a documentation-only PR. So, the next steps would be:
Your discovery and work is valuable, and adding it to the docs is a good way to share it with the community while keeping the default Wasp setup lean. Let me know if that makes more sense, and tell me if you feel like doing that! Again, we're really grateful for your flexibility and willingness to contribute. 🤘 |
To be clear: this was my mistake to ask you to do some work on a plugin, without thinking if we wanted to have it installed by default. I'm sorry 😔! That's why it's perfectly fine if you don't want to follow up. |
@cprecioso am up for it !! will close this pr soon and open a documentation only PR !! |
well no issues !! I loved to code and by you guiding me, i got my name on vite devtools repo !! it should be me thanking you to helping me up in open source !! |
Description
closes #2803
Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects
waspc
, make sure you satisfy the following:ChangeLog.md
with description of the change this PR introduces.waspc
version inwaspc.cabal
to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.Description
Added Chrome DevTools “Automatic Workspace” support to Wasp apps in dev-mode. here is how i implemented it ,
vite/devToolsJson.ts
plugin that serves/.well-known/appspecific/com.chrome.devtools.json
:wasp-cli
launcher now injectsWASP_PROJECT_ROOT
; if its not present plugin falls back to walking up to thefirst directory containing
.wasp/
for projects started directly with Vite.\\wsl.localhost\<distro>\…
, Docker Desktop).crypto.randomUUID()
, persisted innode_modules/.vite/<hash>/uuid.json
.