Type-check generated server code when building #2778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprecioso
force-pushed
the
cprecioso/push-rzywtyrurkqk
branch
from
d0aa7ec to
bc97d47
Compare
cprecioso
changed the title
cprecioso
changed the title
|
@infomiho this worked before merging the app runner for the headless tests, can you take a look? I think it's trying to run |
|
@cprecioso It's related to the building the server container, I believe we should maybe also copy the |
Deploying wasp-docs-on-main with
|
| Latest commit: |
f96359b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fe7def56.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-push-rzywtyrurkqk.wasp-docs-on-main.pages.dev |
|
Ready for review! |
infomiho
reviewed
Jun 2, 2025
| (waspProjectDir </> packageLockJsonInWaspProjectDir) | ||
| packageLockJsonInBuildDir | ||
|
|
||
| liftIO $ |
There was a problem hiding this comment.
I'd add a comment that explains that we need this tsconfig.json file since the server config references the user TS config file. It took me a bit to figure this out when I was reviewing this.
infomiho
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2458
This was approved in #2709, but forgot to keep that when that PR was closed. We bring it back here.