-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Move dope.sh
to top level
#531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c03552
to
1159ea4
Compare
1159ea4
to
01c159c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanations LGTM, left a couple comments. Leaving approved as they are simple.
I haven't downloaded the branch to actually verify the new paths are correct, but I trust you did.
opensaas-sh/README.md
Outdated
brew install gpatch | ||
brew install diffutils | ||
``` | ||
For detailed information about the diff/patch workflow and MacOS setup requirements, see [../tools/README.md](../tools/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick:
For detailed information about the diff/patch workflow and MacOS setup requirements, see [../tools/README.md](../tools/README.md). | |
For detailed information about the diff/patch workflow and macOS setup requirements, see [../tools/README.md](../tools/README.md). |
brand name is macOS 🤪
tools/README.md
Outdated
|
||
## dope.sh - Diff Or Patch Executor | ||
|
||
The `dope.sh` script allows you to easily create a diff between two projects (base and derived), or to patch those diffs onto the base project to get the derived one. This is useful when a derived project has only small changes on top of the base project and you want to keep it in a directory in the same repo as the main project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add here a small sentence saying that having opensaas.sh be in sync with the template was the motivation for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
tools/README.md
Outdated
|
||
### Workflow | ||
|
||
Since derived apps (like opensaas-sh) are just the Open SaaS template with some small tweaks, and we want to keep them up to date as the template changes, we don't version the actual app code in git. Instead, we version the diffs between it and the template in an `app_diff/` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this thing here, I'd lift to the tool intro!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
tools/README.md
Outdated
./dope.sh ../template app diff | ||
``` | ||
|
||
### Running on MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO (feel free to disregard)
### Running on MacOS | |
### Requirements | |
#### macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me from waht I saw, left some comments, but I see @cprecioso has grasp on it so I will let him give the approve and I will stay on the comment level and unsubscribe.
opensaas-sh/tools/diff.sh
Outdated
|
||
TOOLS_DIR=$(dirname "$(realpath "$0")") # Assumes this script is in `tools/`. | ||
cd "${TOOLS_DIR}" && cd ../.. | ||
SCRIPT_DIR=$(dirname "$(realpath "$0")") # Assumes this script is in `opensaas-sh/tools/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not in the correct line anymore I think, I would move it to line below, since assumptions is happening there, with the "/../.."?
opensaas-sh/tools/patch.sh
Outdated
|
||
TOOLS_DIR=$(dirname "$(realpath "$0")") # Assumes this script is in `tools/`. | ||
cd "${TOOLS_DIR}" && cd ../.. | ||
SCRIPT_DIR=$(dirname "$(realpath "$0")") # Assumes this script is in `opensaas-sh/tools/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
tools/README.md
Outdated
@@ -0,0 +1,53 @@ | |||
# Open SaaS Tools | |||
|
|||
This directory contains utilities for managing derived projects that are built on top of the Open SaaS template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha for now, it might contain any kind of tools :D! You could probably even leave this sentence out, maybe you don't need to at the moment "prescribe" what this "tools" dir is about.
raw
tools/README.md
Outdated
|
||
## dope.sh - Diff Or Patch Executor | ||
|
||
The `dope.sh` script allows you to easily create a diff between two projects (base and derived), or to patch those diffs onto the base project to get the derived one. This is useful when a derived project has only small changes on top of the base project and you want to keep it in a directory in the same repo as the main project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
tools/README.md
Outdated
|
||
### Workflow | ||
|
||
Since derived apps (like opensaas-sh) are just the Open SaaS template with some small tweaks, and we want to keep them up to date as the template changes, we don't version the actual app code in git. Instead, we version the diffs between it and the template in an `app_diff/` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@cprecioso ready |
Description
Moves
dope.sh
to top level so it can be used with other apps, not onlyopensaas.sh
. Prerequisite for #530*.copy
support todope.sh
#525 to be merged and resolve any conflicts.Contributor Checklist