Skip to content

Conversation

sodic
Copy link
Collaborator

@sodic sodic commented Sep 10, 2025

I see some warnings

warnings

@sodic sodic requested a review from vincanger September 10, 2025 23:14
@infomiho
Copy link
Collaborator

@fgrgic might know about these Tailwind warnings

Copy link
Collaborator

@infomiho infomiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sodic
Copy link
Collaborator Author

sodic commented Sep 11, 2025

Tailwind warnings are old, just confirmed.

Copy link
Collaborator

@vincanger vincanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing. you need to update the github action >> https://github.com/wasp-lang/open-saas/blob/main/.github/workflows/e2e-tests.yml#L13

@FranjoMindek
Copy link
Contributor

e2e tests are still failing, we are fetching:

curl -sSL https://get.wasp.sh/installer.sh | sh -s -- -v 0.17.0

@FranjoMindek
Copy link
Contributor

Btw we are duplicating work from: https://github.com/wasp-lang/open-saas/pull/480/files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost slipped through, I cherry picked it from #480

@sodic
Copy link
Collaborator Author

sodic commented Sep 12, 2025

Checks passing with the RC: https://github.com/wasp-lang/open-saas/actions/runs/17669926950/job/50219222615

I changed the version back to 0.18.0 so it will fail temporarily.

@sodic sodic merged commit fabbfef into main Sep 12, 2025
1 check failed
@cprecioso
Copy link
Member

@sodic I see you cherry-picked #480 here? Should I close that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants