Fix some UI issues in the footer's action menu #886
+44
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly replaces forms with w-action controllers. The convert-to-alias button used a form unnecessarily. TODO: The publish-form still isn't optimal and probably requires css fixes. Relates to wagtail#885
|
question: we still support Wagtail 6.3 (as LTS). Do the changes work there? |
|
Just tested it with bakerydemo and 6.3. It has the same issue and the changes work there too 🙏 (also tested the introduced w-action buttons) |
|
if it can wait till Friday, will make some time to sort out the CI (Bitnami have archived a bunch of images), and test this locally so we can get it out to improve people's experience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Unfortunately the
w-actioncontroller does not support an "action" form field and therefore the publish-form is still required. So this minor UI issue remains as seen below (without the form the button container would be have the same width as the dropdown). It probably requires css fixes, where I'm not an expert in.Relates to #885