UpdateTranslationsView: sync draft content if available #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sync is executed with the publish_translations-checkbox unchecked, the latest revision's content is synced to the translations. Fixes wagtail#823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #823 (comment) the draft content is not synced, when the "Sync translated pages" action is used.
This allows to change/prepare the content of a source object, without publishing it (yet), and further sync those changes to the translations to prepare those changes to be published later all at once.
I've deviated slightly from my suggestion to introduce a new setting. Instead, the sync only uses the draft content if the "Publish immediately" checkbox is not checked.
What do you think about it? Better use a setting and disable that functionality by default?
Fixes #823