Skip to content

Conversation

emmanuel-ferdman
Copy link
Contributor

Summary

This small PR resolves the bs4 library deprecation warnings:

/home/runner/work/wagtail-localize/wagtail-localize/wagtail_localize/strings.py:478: DeprecationWarning: Call to deprecated method replaceWith. (Replaced by replace_with) -- Deprecated since version 4.0.0.

/home/runner/work/wagtail-localize/wagtail-localize/wagtail_localize/strings.py:363: DeprecationWarning: Call to deprecated method replaceWith. (Replaced by replace_with) -- Deprecated since version 4.0.0.

/home/runner/work/wagtail-localize/wagtail-localize/wagtail_localize/strings.py:476: DeprecationWarning: Call to deprecated method findAll. (Replaced by find_all) -- Deprecated since version 4.0.0.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (9646cec) to head (97699e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files          47       47           
  Lines        4242     4242           
  Branches      551      551           
=======================================
  Hits         3946     3946           
  Misses        177      177           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zerolab zerolab merged commit 165d15e into wagtail:main May 9, 2025
11 checks passed
@zerolab
Copy link
Collaborator

zerolab commented May 9, 2025

Thank you for this!

zerolab pushed a commit that referenced this pull request Jul 14, 2025
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants