Some small gotcha with snippets #836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
========================================
Coverage 93.07% 93.07%
========================================
Files 47 47
Lines 4144 4144
Branches 704 529 -175
========================================
Hits 3857 3857
Misses 173 173
Partials 114 114 ☔ View full report in Codecov by Sentry. |
zerolab
reviewed
Oct 29, 2024
Added a better code example
|
Thanks @onno-timmerman, merged in 2c2600a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using snippets and translations there is a gotcha you might encounter. This might save somebody couple of hours figuring it out.
Imagine you have a page with related tags added via snippets, and you want to query all pages with a specific tag.
When synchronous translation is enabled, the tag will refer to the default language. However, if the user turns off
synchronous translation, the tag will refer to the page’s language. This could mean the user references a translated tag
within the translated page, causing the query to miss some pages tagged with the original tag.
To solve this, you can query both the default language and the current language, then filter based on the active
language.