-
Notifications
You must be signed in to change notification settings - Fork 100
Add a machine translation option when syncing pages #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n concert with publishing option.
zerolab
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start @waldo90
Left a few notes and suggestions for improvement
|
Hi @zerolab, just a wee heads up that this is ready for review again. |
zerolab
added a commit
that referenced
this pull request
Dec 20, 2024
zerolab
added a commit
that referenced
this pull request
Dec 24, 2024
zerolab
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option for machine translation to be performed when synicing page translations as per issue:
#786
It adds the option alongside the existing 'publish immediately' option as I found that these can be made to work togther in all combinations:
This is slightly as odds with what was discussed on the ticket. However, I'm hopeful that the extra flexibility will be welcome.