-
Notifications
You must be signed in to change notification settings - Fork 289
Update user-inactivity.html #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a css "note" class to the paragraph following the definition.
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
put in correct alphabetical order
Discussed and approved on backlog call 11/1. |
Cross linking #4149, I raised an issue after reviewing all the definitions. |
Discussed on backlog call 1/7. Mike agreed to split into two PRs since correcting alphabetical order is an obvious fix. The class change is also editorial, but use of NOTES in spec is a sensitive topic. Stays in For discussion. |
Removing change to index.html (now covered in #4256 ) to make it easier to differentiate between the scale of changes for the two changes to the definitions proposed.
241494c
to
1407529
Compare
Discussed on backlog call 3/7. As noted at top, this PR now separates the corrections. |
Comment from Gregg in the call: We can't change this to a note as it changes the definition. Could update to join the sentences together, e.g. with a "where". |
Couple Comments
now to your suggested change
OR if the method of tracking is not important -- then the note can be
|
I completely agree with this principle, and it is my goal to follow it when creating new normative material. However, the reality is that some notes in the existing standard do clearly affect the definition. The massive discussion we're involved in in #1790, concerning the notes for audio description, is a perfect example. The word "pause" never appears in normative text of the SC or definition; it's in a note, yet it has become the focus of a considerable amount of commentary. In such cases, the best it seems we can hope to do is either leave things alone and put up with the churn, or attempt to do the smallest change that produces a positive outcome for the standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can anyone think of a scenario where not having the sentence would change the results of an audit? It seems like a pretty obvious statement of fact.
This was a motivator in why we were proposing this change. However, note that there are 10 definitions in WCAG that exceed one sentence and a half dozen others that are list structures. Alastair identified a number of other definitions that are constructed similar to this one and seem to be candidates for the second sentence being a note. #4149
I've noted that almost all the definitions do not end in terminal punctuation, which reinforces that idea; however, I identified 2 SCs that end in periods that can stand without them, and will generate a small normative PR to change those. |
Noting that the very first draft of this (for WCAG 2.1), started off as one paragraph. I'm inclined to drop this change, although we should avoid such framing in future. |
Added a css "note" class to the paragraph following the definition.
Resolves #4117
Note: the reorder for alphabetically listing the definitions, that was previously part of this change, is now covered by #4256
Preview | Diff