Fix typo in example 128 on compacting #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-scherbakov
approved these changes
Feb 9, 2025
gkellogg
approved these changes
Mar 10, 2025
|
bretelerjmw marked as non substantive for IPR from ash-nazg. |
Contributor
Author
|
Hi there, What's the next step in merging this change? Should I have targeted a different branch? I could not find information about this in the CONTRIBUTING document or the IPR page. |
|
hi @bretelerjmw — thank you for fixing this! I am still not very much familiar with the process but I think a review from @pchampin is required? |
pchampin
approved these changes
Apr 18, 2025
Contributor
not formally required, but there it is anyway... |
|
Thanks @pchampin! I thought your review was required to make the PR mergeable but it is still not 🤔 |
Contributor
|
@anatoly-scherbakov it is more a permission thing, I believe. Only editors and chairs can merge PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff