Use doctrine/orm:^3.0 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good PR, let's have it merged :) |
|
Sorry, I've forgotten to update this PR. This change has been tested and is in production since a few weeks already. No issues. |
|
Thanks @jean-gui. I've merged the branch and made a new 5.0.0 release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've already created a version with this branch for our app, which uses a lot of functions in this bundle. The tests are green and on first sight, there doesn't seem to be an issue.
My tester will be back in two weeks. He will then test the app extensively to find issues which our tests might not have covered. I'll change this PR from WIP to ready as soon as he's finished testing.