Skip to content

Define Coordinator and Client #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Define Coordinator and Client #306

wants to merge 12 commits into from

Conversation

marcoscaceres
Copy link
Collaborator

@marcoscaceres marcoscaceres commented Jun 30, 2025

Closes #305


Preview | Diff

@marcoscaceres marcoscaceres requested a review from a team as a code owner June 30, 2025 07:12
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small language fix

@marcoscaceres marcoscaceres requested a review from mohamedamir July 1, 2025 02:54
marcoscaceres and others added 3 commits July 2, 2025 11:26
index.html Outdated
Comment on lines 367 to 374
<li>Interprets each individual request in the input list as targeting a
specific [=holder=], and prepares holder options accordingly.
</li>
<li>Presents the available [=holders=] to the user for selection.
</li>
<li>Once a [=holder=] is selected, invokes it as a [=credential chooser=]
to complete the interaction.
</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably Webkit-specific.
In Chrome all that logic lives in Android, and doesn't really belong to the user-agent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also in Cross-Device, that logic doesn't live in the client even in Webkit (as in the Client to Authenticator Protocol)

I suggest we remove this from the responsibilities of the client.
It's sufficient to say as above, that it facilitates the selection of the holder
This covers "Webkits actual displaying of the selector, Chrome delegation to platform, and cross-device's delegation to the authenticator)

What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with dropping this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some of this in the PR.
Is that intentional?

marcoscaceres and others added 4 commits July 7, 2025 14:42
Co-authored-by: Mohamed Amir Yosef <mohamed.amir@gmail.com>
Co-authored-by: Mohamed Amir Yosef <mohamed.amir@gmail.com>
Co-authored-by: Mohamed Amir Yosef <mohamed.amir@gmail.com>
Co-authored-by: Mohamed Amir Yosef <mohamed.amir@gmail.com>
<p>
A <dfn>digital credential client</dfn> is a user-agent-defined component
responsible managing the credential presentation or issuance flow, which
includes allowing a user to select from available [=holders=] and coordinating the request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
includes allowing a user to select from available [=holders=] and coordinating the request.
includes allowing the user to select from available [=holders=] and coordinating the request.

@@ -349,29 +349,26 @@ <h3>
</h3>
<p>
A <dfn>digital credential client</dfn> is a user-agent-defined component
responsible for presenting available [=holders=] to the user and
coordinating the credential request or issuance flow.
responsible managing the credential presentation or issuance flow, which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
responsible managing the credential presentation or issuance flow, which
responsible for managing the credential presentation or issuance flow, which

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define coordinator and client
3 participants