-
-
Notifications
You must be signed in to change notification settings - Fork 41
Fix for #169 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for #169 #192
Conversation
…bling up to the TableView, causing unintended row selection or scrolling. This fix: - marks the Space key event as handled when focus is in the search box - manually inserts a space character into the TextBox at the caret - prevents TableView from reacting to Space input during search Fixes w-ahmad#169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue why this happen is because the search box and the filter list is within the template of a menu item which is using space button to invoke it. the correct solution is to replace the menu bar flyout with a standard flyout and then add options in it. Of course, it will take some time to match the UI/UX to the existing flyout.
|
Hi @w-ahmad, Thanks for your feedback and for maintaining this great project! I understand your point about the root cause being the use of a flyout-menu item template for the filter, which causes the spacebar to trigger the menu’s default behavior. However, since the issue only occurs when the search box is focused, handling the spacebar event in the TextBox itself shouldn’t interfere with the standard flyout/menu behavior for other controls. Esc still closes the flyout, Enter still applies the filter, and the workaround only affects the search box, so it feels like a safe and practical fix for now that provides standard possibility to enter text in a searchbox. I agree with your suggestion that, in the long run, the filter/options menu should be reworked to use a popup instead of a flyout. This would allow for a more advanced and resizable UI, similar to Excel, and would make it easier to display and interact with larger filter lists or more complex content. For now, I think it makes sense to merge this workaround to improve usability, and I’ll open a separate issue #198 to track the proposal for a more robust, popup-based filter/options dialog in the future. Thanks again for your consideration! |
|
Thank you @SISTF for your contribution. I'm planning to fix this issue in v1.4, hopefully later this year so we have plenty of time to rewrite the XAML of the flyout or to implement the popup that you suggested in related issue. I would say that let's park this PR for now and if I couldn't be able to do it we can merge this PR to at least resolve the issue. |
Hi, are you thinking of fixing all IME input methods like not being able to type Chinese/Japanese via IM method in filter? |
@lostluna1 Yes, I'll try my best to provide a fix for this in upcoming release. |
When typing in the embedded search TextBox, pressing Spacebar was bubbling up to the TableView,
causing unintended row selection or scrolling.
This fix:
Fixes #169