Skip to content

feat(helper): improve darkmode #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

feat(helper): improve darkmode #540

merged 2 commits into from
Jun 18, 2025

Conversation

Mister-Hope
Copy link
Member

Now, themes are required to import darkmodeSymbol from @vuepress/helper and provides darkmode variable in root setup function.

This avoids plugins that need darkmode status always being initialized with darkmode: false then a possible update.

@Mister-Hope Mister-Hope requested a review from pengzhanbo June 18, 2025 10:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15730038865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.616%

Totals Coverage Status
Change from base Build 15725412139: 0.0%
Covered Lines: 1420
Relevant Lines: 2092

💛 - Coveralls

@Mister-Hope Mister-Hope enabled auto-merge (squash) June 18, 2025 10:23
@Mister-Hope Mister-Hope merged commit cc167e7 into main Jun 18, 2025
39 of 41 checks passed
@Mister-Hope Mister-Hope deleted the darkmode branch June 18, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants