fix(vapor): v-model and v-model:model co-usage #13070

zhiyuanzmj · 2025-03-19T10:10:55Z

When defineModel() and defineModel('model') co-usage, will got duplicated modifiers.
This is also effect Volar to infer modifiers type, so modelModifiers should be change to modelValueModifiers

REPL

pkg-pr-new · 2025-03-19T10:19:22Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13070

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13070

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13070

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13070

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13070

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13070

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13070

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13070

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13070

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13070

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13070

vue

npm i https://pkg.pr.new/vue@13070

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13070

commit: f3b3cbd

github-actions · 2025-03-19T10:20:15Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	100 kB (-53 B)	38.1 kB (-18 B)	34.3 kB (-11 B)
vue.global.prod.js	158 kB (-48 B)	58 kB (-14 B)	51.6 kB (+6 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.5 kB (-53 B)	18.2 kB (-19 B)	16.7 kB (-24 B)
createApp	54.5 kB (-53 B)	21.3 kB (-17 B)	19.4 kB (-48 B)
createSSRApp	58.7 kB (-53 B)	23 kB (-21 B)	20.9 kB (-24 B)
defineCustomElement	59.3 kB (-53 B)	22.9 kB (-19 B)	20.8 kB (-29 B)
overall	68.6 kB (-53 B)	26.4 kB (-19 B)	24.1 kB (+29 B)

coderabbitai · 2025-06-17T13:37:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yyx990803

This edge case isn't worth the potential breakage, especially when the changes not only affect vapor but also vdom mode.

We can do something in reverse - special case when the model name is "model"

generate the prop key as model$Modifiers
in getModelModifiers, also special case it

Not as clean as aligning with modelValue, but it prevents any possible breakage.

netlify · 2025-07-03T14:02:17Z

✅ Deploy Preview for vapor-repl ready!

Name	Link
🔨 Latest commit	`f3b3cbd`
🔍 Latest deploy log	https://app.netlify.com/projects/vapor-repl/deploys/6866b4eb259d510008c46c95
😎 Deploy Preview	https://deploy-preview-13070--vapor-repl.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

KazariEX · 2025-07-03T15:13:01Z

So what if I define a model called model$?

zhiyuanzmj · 2025-07-03T15:17:47Z

Only hope no one to do it 😔.

yyx990803 · 2025-07-03T15:18:12Z

So what if I define a model called model$?

Should be avoidable if using modelModifiers$ instead?

KazariEX · 2025-07-03T15:30:43Z

I think that adding more technical debt here is not ideal. This is where the complexity of the codebase starts to spiral. We should bear the cost of our past design mistakes. This modification even resulted in two locations where this feature behaved inconsistently.

zhiyuanzmj · 2025-07-03T15:37:09Z

And the dynamic modelName also has problems.

yyx990803 · 2025-07-03T16:17:59Z

It's indeed a past design mistake so we have to absorb the complexity to avoid breaking changes.

yyx990803

It seems we can extract a shared function

// explain why this is needed and link to this PR
function getModifierPropName(key) {
  return `${key}Modifiers${key === 'model' ? '$' : ''}`
}

zhiyuanzmj · 2025-07-03T16:51:06Z

Done.

edison1105 added scope: vapor related to vapor mode ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed scope: vapor related to vapor mode labels Mar 19, 2025

zhiyuanzmj mentioned this pull request Mar 20, 2025

fix(volar/jsx-directive): use modelValueModifiers instead of modelModifiers vue-macros/vue-macros#936

Merged

zhiyuanzmj added 2 commits March 20, 2025 10:10

fix: use modelValueModifiers intead of modelModifiers

8b7a035

feat: use for vapor

9df9281

zhiyuanzmj force-pushed the fix-define-model branch from 85a90cc to 9df9281 Compare March 20, 2025 02:36

zhiyuanzmj changed the base branch from main to vapor March 20, 2025 02:36

zhiyuanzmj added the scope: vapor related to vapor mode label Mar 20, 2025

edison1105 force-pushed the vapor branch from 66c6902 to f78a9d0 Compare May 8, 2025 10:02

zhiyuanzmj added the breaking change label Jun 17, 2025

edison1105 changed the title ~~fix: use modelValueModifiers instead of modelModifiers~~ fix(vapor): use modelValueModifiers instead of modelModifiers Jun 20, 2025

yyx990803 reviewed Jul 3, 2025

View reviewed changes

chore: use model$

c4e45ff

zhiyuanzmj changed the title ~~fix(vapor): use modelValueModifiers instead of modelModifiers~~ fix: v-model and v-model:model co-usage Jul 3, 2025

chore: update

d22026a

zhiyuanzmj changed the title ~~fix: v-model and v-model:model co-usage~~ fix(vapor): v-model and v-model:model co-usage Jul 3, 2025

chore: update

2029be5

yyx990803 reviewed Jul 3, 2025

View reviewed changes

chore: add getModifierPropName

f3b3cbd

edison1105 deleted the branch vuejs:minor July 7, 2025 00:06

edison1105 closed this Jul 7, 2025

zhiyuanzmj reopened this Jul 7, 2025

zhiyuanzmj changed the base branch from vapor to minor July 7, 2025 00:52

Uh oh!

fix(vapor): v-model and v-model:model co-usage #13070

Are you sure you want to change the base?

fix(vapor): v-model and v-model:model co-usage #13070

Conversation

zhiyuanzmj commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2025

Size Report

Bundles

Usages

Uh oh!

coderabbitai bot commented Jun 17, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

yyx990803 left a comment

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vapor-repl ready!

Uh oh!

KazariEX commented Jul 3, 2025

Uh oh!

zhiyuanzmj commented Jul 3, 2025

Uh oh!

yyx990803 commented Jul 3, 2025

Uh oh!

KazariEX commented Jul 3, 2025

Uh oh!

zhiyuanzmj commented Jul 3, 2025

Uh oh!

yyx990803 commented Jul 3, 2025

Uh oh!

yyx990803 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhiyuanzmj commented Jul 3, 2025

Uh oh!

Uh oh!

zhiyuanzmj commented Mar 19, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jul 3, 2025 •

edited

Loading

yyx990803 left a comment •

edited

Loading