fix(compiler-sfc): add scoping tag to trailing universal selector #12918

thecodewarrior · 2025-02-20T00:11:26Z

Summary by CodeRabbit

Tests
- Expanded test coverage for scoped CSS to include more complex selector scenarios involving universal selectors and pseudo-classes.
Bug Fixes
- Improved handling of scoped CSS attributes for selectors with trailing universal selectors, ensuring correct application in advanced CSS combinations.

github-actions · 2025-02-20T00:18:12Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.6 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24.1 kB

pkg-pr-new · 2025-02-20T00:18:27Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12918

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12918

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12918

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12918

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12918

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12918

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12918

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12918

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12918

vue

npm i https://pkg.pr.new/vue@12918

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12918

commit: d76c8e6

packages/compiler-sfc/src/style/pluginScoped.ts

edison1105 · 2025-02-20T00:56:51Z

LGTM

Doctor-wu

LGTM

coderabbitai · 2025-05-19T00:51:16Z

Walkthrough

The changes update the CSS scoping logic in the Vue SFC compiler to handle universal (*) selectors more precisely, ensuring scoped attributes are correctly injected for selectors like .foo *, .foo *:active, and similar cases. Corresponding tests were expanded to cover these scenarios and verify correct behavior.

Changes

File(s)	Change Summary
packages/compiler-sfc/src/style/pluginScoped.ts	Enhanced `rewriteSelector` to track and process universal selectors, injecting scoped attributes as needed.
packages/compiler-sfc/tests/compileStyle.spec.ts	Expanded test coverage for scoped CSS with universal selectors and pseudo-classes.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant SFCCompiler
    participant StylePluginScoped

    Developer->>SFCCompiler: Add scoped style with universal selector (e.g., .foo * { ... })
    SFCCompiler->>StylePluginScoped: Process selector for scoping
    StylePluginScoped->>StylePluginScoped: Track universal selector nodes
    StylePluginScoped->>StylePluginScoped: Inject scoped attribute after class and universal selectors
    StylePluginScoped-->>SFCCompiler: Return rewritten, correctly scoped selector
    SFCCompiler-->>Developer: Output compiled CSS with proper scoping

Assessment against linked issues

Objective	Addressed	Explanation
Correctly scope universal selectors to prevent style leakage into children (#12906)	✅
Ensure selectors like `.foo `, `.foo :active`, and similar are rewritten with both nodes scoped (#12906)	✅
Maintain expected scoping for pseudo-classes and descendant selectors as per Vue 2 parity (#12906)	✅

Poem

🐇
A star once wandered, wild and free,
Leaking styles where none should be.
Now scoped and tamed, selectors shine,
With [--] in place, all works fine.
The tests all pass, the bug is gone—
Hooray for code that hops along!
🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 163b365 and e8209b4.

📒 Files selected for processing (2)

packages/compiler-sfc/__tests__/compileStyle.spec.ts (1 hunks)
packages/compiler-sfc/src/style/pluginScoped.ts (3 hunks)

🔇 Additional comments (6)

packages/compiler-sfc/src/style/pluginScoped.ts (4)

105-105: LGTM: Good addition for tracking universal selectors.

Adding this variable allows tracking universal selectors during traversal so they can be properly handled with scoping attributes later.

220-222: Clear comment that explains the intent.

This comment clarifies the purpose of storing the universal selector node - to enable proper rewriting with scoped attributes.

226-229: LGTM: Appropriate variable handling logic.

The condition is correctly updated to consider universal selectors in the node type check, and starNode is properly reset when a non-special node is found.

Also applies to: 234-234

282-295: Excellent fix for trailing universal selectors.

This implementation properly handles trailing universal selectors by:

Adding a scoped attribute before the universal selector

Removing the original universal selector

This ensures that selectors like .foo * are correctly scoped as .foo[data-v-test] [data-v-test], preventing style leakage while maintaining the original selector's intent.

packages/compiler-sfc/__tests__/compileStyle.spec.ts (2)

496-498: LGTM: Updated expected output for universal selector.

The test for .foo * { color: red; } now correctly expects the output to include scoping attributes on both the parent selector and in place of the universal selector.

499-521: Great test coverage for various universal selector scenarios.

These additional test cases thoroughly verify the fix by covering multiple scenarios:

Simple pseudo-class (.foo :active)

Universal selector with pseudo-class (.foo *:active)

Universal selector in the middle of a complex selector (.foo * .bar)

Universal selector after pseudo-class (:last-child *)

Universal selector with surrounding pseudo-classes (:last-child *:active)

This comprehensive test coverage ensures the implementation correctly handles all edge cases.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

edison1105 · 2025-05-22T00:27:29Z

/ecosystem-ci run

vue-bot · 2025-05-22T00:36:42Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
radix-vue	✅ success	✅ success
test-utils	✅ success	✅ success
router	✅ success	✅ success
nuxt	✅ success	✅ success
pinia	✅ success	✅ success
vant	✅ success	✅ success
primevue	✅ success	✅ success
vue-macros	✅ success	✅ success
vue-i18n	✅ success	✅ success
vitepress	✅ success	✅ success
quasar	✅ success	✅ success
language-tools	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vuetify	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success
vueuse	✅ success	✅ success

skirtles-code · 2025-05-28T21:03:58Z

I've created #13405 for further discussion of how to handle trailing * selectors.

fix(compiler-sfc): add scoping tag to trailing universal selector

9b0bf77

edison1105 reviewed Feb 20, 2025

View reviewed changes

packages/compiler-sfc/src/style/pluginScoped.ts Outdated Show resolved Hide resolved

edison1105 requested a review from Doctor-wu February 20, 2025 00:53

edison1105 added scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 20, 2025

Apply suggestions from code review

0a03626

edison1105 reviewed Feb 20, 2025

View reviewed changes

packages/compiler-sfc/src/style/pluginScoped.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

92621b8

edison1105 added the ready to merge The PR is ready to be merged. label Feb 20, 2025

Doctor-wu approved these changes Feb 21, 2025

View reviewed changes

Merge branch 'main' into fix/12906-universal-selector-scope

e8209b4

edison1105 approved these changes May 19, 2025

View reviewed changes

edison1105 approved these changes May 21, 2025

View reviewed changes

Merge branch 'main' into fix/12906-universal-selector-scope

d76c8e6

vuejs deleted a comment from edison1105 May 22, 2025

edison1105 merged commit 949df80 into vuejs:main May 22, 2025
14 checks passed

edison1105 mentioned this pull request May 27, 2025

CSS direct descendant wildcard rule no longer applied to child components #13387

Closed

coderabbitai bot mentioned this pull request May 27, 2025

fix(compiler-sfc): don't inject scope id before child combinator > #13389

Closed

edison1105 mentioned this pull request May 28, 2025

With Vue 3.5.15, bootstrap5 and sass, grid system does not work properly #13401

Closed

coderabbitai bot mentioned this pull request May 28, 2025

fix(compiler-sfc): replace trailing universal selector with :where([id]) in scoped styles #13404

Closed

This was referenced May 29, 2025

Revert "fix(compiler-sfc): add scoping tag to trailing universal selector" #13406

Merged

Star selectors leak scoped styles into children #12906

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(compiler-sfc): add scoping tag to trailing universal selector #12918

fix(compiler-sfc): add scoping tag to trailing universal selector #12918

thecodewarrior commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

github-actions bot commented Feb 20, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

edison1105 commented Feb 20, 2025

Uh oh!

Doctor-wu left a comment

Uh oh!

coderabbitai bot commented May 19, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

edison1105 commented May 22, 2025

Uh oh!

vue-bot commented May 22, 2025

Uh oh!

Uh oh!

skirtles-code commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

fix(compiler-sfc): add scoping tag to trailing universal selector #12918

fix(compiler-sfc): add scoping tag to trailing universal selector #12918

Conversation

thecodewarrior commented Feb 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

github-actions bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

edison1105 commented Feb 20, 2025

Uh oh!

Doctor-wu left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

edison1105 commented May 22, 2025

Uh oh!

vue-bot commented May 22, 2025

Uh oh!

Uh oh!

skirtles-code commented May 28, 2025

Uh oh!

Uh oh!

thecodewarrior commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 20, 2025 •

edited

Loading

coderabbitai bot commented May 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)