This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Some fixes for UTF-8 decode, and Close frames #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and message in close frames.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some testing while building a client against a live service turned up a few issues with this library. This commit fixes two problems:
Close messages may have a payload containing a 2-byte uint16 error number, and then a UTF-8 message in the payload. These were not handled on receive or send.
Frame class always converted payload to/from UTF-8, but this is really only correct for Text frames. Control frames and Binary frames should not be converted.
This patch adds correct handling of Close frames, and changes the Frame class to only encode/decode UTF-8 for Text frames.