Mark Buckets as deterministic external name #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pending-annotation often gets triggered on clusters with a higher API load. As buckets have inherently deterministic names, the annotation doesn't provide any additional benefits, while increasing manual intervention by a lot.
Kidswiss
requested review from
a team,
TheBigLee,
mdnix and
wejdross
and removed request for
a team
mdnix
approved these changes
Jun 11, 2025
zugao
approved these changes
Jun 12, 2025
TheBigLee
approved these changes
Jun 13, 2025
|
|
||
| if iamKey.Status.AtProvider.RoleID == "" { | ||
| iamKey.Status.AtProvider.ServicesSpec.SOS.Buckets = getBuckets(pctx.iamExoscaleKey.Resources) | ||
| iamKey.Status.AtProvider.SOS.Buckets = getBuckets(pctx.iamExoscaleKey.Resources) |
There was a problem hiding this comment.
Why is this changing exactly? The commit message for this change doesn't really help to understand it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pending-annotation often gets triggered on clusters with a higher API load.
As buckets have inherently deterministic names, the annotation doesn't provide any additional benefits, while increasing manual intervention by a lot.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make test-e2elocally.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.