Make sure secrets get applied early #957
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
a team,
TheBigLee,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
Due to ArgoCD being ArgoCD the very first sync with "server-side-apply" will hang. This generates a race condition with kindev non-converged provisioning as we need some service account token secrets to generate kube-configs. By applying secrets early we can ensure that they actually get deployed even if ArgoCD gets stuck.
Kidswiss
force-pushed
the
fix/wrong_vcluster_config
branch
from
15bc61c to
b0eb468
Compare
TheBigLee
approved these changes
Oct 14, 2025
mdnix
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to ArgoCD being ArgoCD the very first sync with "server-side-apply" will hang.
This generates a race condition with kindev non-converged provisioning as we need some service account token secrets to generate kube-configs.
By applying secrets early we can ensure that they actually get deployed even if ArgoCD gets stuck.
Relates to: vshn/kindev#43
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make e2e-testagainst local kindev and all checks passed