Skip to content

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jul 2, 2025

This action was copied from vshn/appcat, where the component_token variable is defined and used for pulling. However it doesn't exist in the component-appcat repository. Leading to an error during release.

By removing it, it will default to the actions token, which has enough permissions to do the release on this repository.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • I run make e2e-test against local kindev and all checks passed
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the patch label Jul 2, 2025
@Kidswiss Kidswiss force-pushed the fix/release_action branch from 170942d to 64b8e52 Compare July 8, 2025 13:50
Kidswiss added 2 commits July 8, 2025 13:51
This action was copied from `vshn/appcat`, where the component_token
variable is defined and used for pulling. However it doesn't exist
in the component-appcat repository. Leading to an error during release.

By removing it, it will default to the actions token, which has enough
permissions to do the release on this repository.
@Kidswiss Kidswiss force-pushed the fix/release_action branch from 64b8e52 to b3b0393 Compare July 8, 2025 13:51
@Kidswiss Kidswiss requested review from a team, TheBigLee, ThisIsntTheWay, mdnix and zugao and removed request for a team July 8, 2025 13:52
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants