Also allow Sensitive for rootdn #450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabelenda
force-pushed
the
also_allow_rootdn_sensitive
branch
from
553ec4b to
1df7e6f
Compare
|
@dabelenda thanks for the PR. Can you please add a test that sets the parameter to a sensitive value? |
Sensitive is made to hide information about the type contained inside it, so String[1] is hard to get with most implementation of lookup that return secret data.
dabelenda
force-pushed
the
also_allow_rootdn_sensitive
branch
from
1df7e6f to
3662d88
Compare
|
Sorry, I am currently validating in our infrastructure... and it seems that I have trouble due to the interaction between Sensitive and Deferred ... The typing in that case is not as straightforward as described in this PR... |
|
I will close this PR until I have sorted out my issues. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Sometimes the rootdn (username) is also considered sensitive enough to be left out of PuppetDB and the Logs.
In our case, the same datasource is used for both the rootdn and rootpw and it is automatically wrapped into a Sensitive[Deferred] since our Agents have direct access to the secrets without going through the Server.
This Pull Request (PR) fixes the following issues
Not reported as an issue before creating the PR.