Skip to content

Fix check of compatible parent type #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GraphQL/CorrespondanceRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ private function listFieldResolvedValueTypes(
$expectedParentType = $resolverClassType->getTemplateType(Vojtechdobes\GraphQL\FieldResolver::class, 'TObjectValue');

foreach ($this->listObjectTypeResolvedValueTypes($scope, $schemaServiceOraculum, $objectType) as $parentType) {
if ($parentType->isSuperTypeOf($expectedParentType)->yes() === false) {
if ($expectedParentType->isSuperTypeOf($parentType)->yes() === false) {
$errors[] = sprintf(
"Resolver %s of field %s expects parent to be %s, but parent is resolved to %s",
$resolverClassType->describe(PHPStan\Type\VerbosityLevel::precise()),
Expand Down
14 changes: 13 additions & 1 deletion tests-shared/AbstractCorrespondanceRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,19 @@ final public function testRule(): void
-1,
],
[
"Resolver Vojtechdobes\TestsShared\Resolvers\InvalidParentTypeNameFieldResolver of field InvalidParentType.name expects parent to be Vojtechdobes\TestsShared\Resolvers\Person, but parent is resolved to array{}",
"Resolver Vojtechdobes\TestsShared\Resolvers\PersonParentTypeNameFieldResolver of field PersonParentType.name expects parent to be Vojtechdobes\TestsShared\Resolvers\Person, but parent is resolved to array{}",
-1,
],
[
"Resolver Vojtechdobes\TestsShared\Resolvers\PersonParentTypeNameFieldResolver of field PersonParentType.name expects parent to be Vojtechdobes\TestsShared\Resolvers\Person, but parent is resolved to Vojtechdobes\TestsShared\Resolvers\Entity",
-1,
],
[
"Resolver Vojtechdobes\TestsShared\Resolvers\PersonParentTypeNameFieldResolver of field PersonParentType.name expects parent to be Vojtechdobes\TestsShared\Resolvers\Person, but parent is resolved to Vojtechdobes\TestsShared\Resolvers\Thing",
-1,
],
[
"Resolver Vojtechdobes\TestsShared\Resolvers\EntityParentTypeNameFieldResolver of field EntityParentType.name expects parent to be Vojtechdobes\TestsShared\Resolvers\Entity, but parent is resolved to array{}",
-1,
],
]);
Expand Down
11 changes: 11 additions & 0 deletions tests-shared/Resolvers/Entity.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;


interface Entity
{

public string $name { get; }

}
19 changes: 19 additions & 0 deletions tests-shared/Resolvers/EntityParentTypeNameFieldResolver.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<Entity, string>
*/
final class EntityParentTypeNameFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return $objectValue->name;
}

}
2 changes: 1 addition & 1 deletion tests-shared/Resolvers/Person.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Vojtechdobes\TestsShared\Resolvers;


final class Person
final class Person implements Entity
{

public function __construct(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @implements Vojtechdobes\GraphQL\FieldResolver<Person, string>
*/
final class InvalidParentTypeNameFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
final class PersonParentTypeNameFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, array{}>
*/
final class QueryProviderOfInvalidParentTypeFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
final class QueryProviderOfInvalidEntityParentTypeArrayFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, array{}>
*/
final class QueryProviderOfInvalidPersonParentTypeArrayFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return [];
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Entity>
*/
final class QueryProviderOfInvalidPersonParentTypeEntityFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Person(name: 'Almond');
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Thing>
*/
final class QueryProviderOfInvalidPersonParentTypeThingFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Thing(name: 'Almond');
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Entity>
*/
final class QueryProviderOfValidEntityParentTypeEntityFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Thing(name: 'Almong');
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Person>
*/
final class QueryProviderOfValidEntityParentTypePersonFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Person(name: 'Alice');
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Thing>
*/
final class QueryProviderOfValidEntityParentTypeThingFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Thing(name: 'Almond');
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;

use Vojtechdobes;


/**
* @implements Vojtechdobes\GraphQL\FieldResolver<null, Person>
*/
final class QueryProviderOfValidPersonParentTypePersonFieldResolver implements Vojtechdobes\GraphQL\FieldResolver
{

public function resolveField(mixed $objectValue, Vojtechdobes\GraphQL\FieldSelection $field): mixed
{
return new Person(name: 'Almond');
}

}
13 changes: 13 additions & 0 deletions tests-shared/Resolvers/Thing.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php declare(strict_types=1);

namespace Vojtechdobes\TestsShared\Resolvers;


final class Thing implements Entity
{

public function __construct(
public readonly string $name,
) {}

}
22 changes: 17 additions & 5 deletions tests-shared/schema.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,30 @@ type Query {
arrayType: ArrayType!
objectType: ObjectType!

providerOfInvalidParentType: InvalidParentType!
providerOfInvalidPersonParentTypeArray: PersonParentType!
providerOfInvalidPersonParentTypeEntity: PersonParentType!
providerOfInvalidPersonParentTypeThing: PersonParentType!
providerOfValidPersonParentTypePerson: PersonParentType!

providerOfInvalidEntityParentTypeArray: EntityParentType!
providerOfValidEntityParentTypeEntity: EntityParentType!
providerOfValidEntityParentTypePerson: EntityParentType!
providerOfValidEntityParentTypeThing: EntityParentType!
}

type ArrayType {
a: String!
}

type InvalidParentType {
name: String!
}

type ObjectType {
withGetter: String!
withProperty: String!
}

type PersonParentType {
name: String!
}

type EntityParentType {
name: String!
}
14 changes: 12 additions & 2 deletions tests/CustomAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,18 @@ public function getFieldResolverProvider(string $schemaName): Vojtechdobes\Graph
'ObjectType.withGetter' => new Vojtechdobes\GraphQL\GetterFieldResolver(),
'ObjectType.withProperty' => new Vojtechdobes\GraphQL\PropertyFieldResolver(),

'Query.providerOfInvalidParentType' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfInvalidParentTypeFieldResolver(),
'InvalidParentType.name' => new Vojtechdobes\TestsShared\Resolvers\InvalidParentTypeNameFieldResolver(),
'Query.providerOfInvalidPersonParentTypeArray' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfInvalidPersonParentTypeArrayFieldResolver(),
'Query.providerOfInvalidPersonParentTypeEntity' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfInvalidPersonParentTypeEntityFieldResolver(),
'Query.providerOfInvalidPersonParentTypeThing' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfInvalidPersonParentTypeThingFieldResolver(),
'Query.providerOfValidPersonParentTypePerson' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfValidPersonParentTypePersonFieldResolver(),

'Query.providerOfInvalidEntityParentTypeArray' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfInvalidEntityParentTypeArrayFieldResolver(),
'Query.providerOfValidEntityParentTypeEntity' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfValidEntityParentTypeEntityFieldResolver(),
'Query.providerOfValidEntityParentTypePerson' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfValidEntityParentTypePersonFieldResolver(),
'Query.providerOfValidEntityParentTypeThing' => new Vojtechdobes\TestsShared\Resolvers\QueryProviderOfValidEntityParentTypeThingFieldResolver(),

'PersonParentType.name' => new Vojtechdobes\TestsShared\Resolvers\PersonParentTypeNameFieldResolver(),
'EntityParentType.name' => new Vojtechdobes\TestsShared\Resolvers\EntityParentTypeNameFieldResolver(),
]);
}

Expand Down