-
Notifications
You must be signed in to change notification settings - Fork 2.4k
gtk4: update to 4.20.1 #57329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
gtk4: update to 4.20.1 #57329
Conversation
|
The documentation check failures seems to be an upstream issue (for some reason gi-docgen prefixes its messages with |
Yeah, maybe better to wait until upstream is fixed. |
|
I made the proposed change to the template, just to have it fixed. But I am still totally ok with closing this PR as well. (And, of course, once again, I forgot to change the revision before pushing..., sorry for that. I'm using "revision=0" locally so that the package gets "updated" once the official void package is available.) |
It's a minor issue (just documentation), I can make an issue on the gitlab later. Also the commits need to be squashed (it should be one commit per package), you can do: |
Like so? |
Yes. |
|
Thank you for your help! Usually I delete the branch locally and start fresh or I do reset with "--hard" (because that's how I "learned" it from someone), so this time without it, the template wasn't reset - a nice experience. :-) |
|
Done, sorry for the delay: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/9033.patch |
|
Seems this breaks searching in the app chooser (e.g. in nautilus): https://gitlab.gnome.org/GNOME/gtk/-/issues/7770 |
I'm on xfce. "Open with" on Thunar works fine to me. Probably a nautilus thing. As this bug is now known, better wait for a fixed nautilus release before updating gtk4... So, whatever you think of doing to this PR is fine with me. |
Thunar uses gtk3. |
Oh, ok. Probably because of the same version number I assumed xfce and thus Thunar would use gtk4 already... my bad. |
Co-authored-by: oreo639 <oreo6391@gmail.com>
Testing the changes
Local build testing