vscode: update to 1.99.3 #54742
Merged
vscode: update to 1.99.3 #54742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No way vscode would mandate 16GB RAM as minimum system requirement! |
|
Not during run-, but during compile time... |
|
what if we disable parallel build? is it even doing things in parallel? |
|
Workers are the JS version of threads, so it is safe to assume that stuff runs in parallel. However, running it parallel should reduce the build time in CI. |
|
Calling gulp with --series, --optimize-for-size and setting the RAM limit to 16GB ensured a working build for me. |
|
please squash the commits |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
I get the error message
probably due to my personal system being limited to 8GB of RAM.
Update: I had to change a few bits, but I finally fixed the build. It now requires 16GB at least (using swap works fine, but slows things down considerably).