Skip to content

fix: set sync_time_with_host to default to true #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: set sync_time_with_host to default to true #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions vsphere/virtual_machine_config_structure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,20 +151,21 @@ func schemaVirtualMachineConfigSpec() map[string]*schema.Schema {
"sync_time_with_host": {
Type: schema.TypeBool,
Optional: true,
Default: true,
Description: "Enable guest clock synchronization with the host. On vSphere 7.0 U1 and above, with only this setting the clock is synchronized on startup and resume. Requires VMware Tools to be installed.",
},
"sync_time_with_host_periodically": {
Type: schema.TypeBool,
Optional: true,
Description: "Enable periodic clock synchronization with the host. Supported only on vSphere 7.0 U1 and above. On prior versions setting `sync_time_with_host` is enough for periodic synchronization. Requires VMware Tools to be installed.",
},
"tools_upgrade_policy": {
Type: schema.TypeString,
Optional: true,
Default: string(types.UpgradePolicyManual),
Description: "Set the upgrade policy for VMware Tools. Can be one of `manual` or `upgradeAtPowerCycle`.",
ValidateFunc: validation.StringInSlice(virtualMachineUpgradePolicyAllowedValues, false),
},
"sync_time_with_host_periodically": {
Type: schema.TypeBool,
Optional: true,
Description: "Enable periodic clock synchronization with the host. Supported only on vSphere 7.0 U1 and above. On prior versions setting `sync_time_with_host` is enough for periodic synchronization. Requires VMware Tools to be installed.",
},
"run_tools_scripts_after_power_on": {
Type: schema.TypeBool,
Optional: true,
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/virtual_machine.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ The following options control VMware Tools settings on the virtual machine:

* `run_tools_scripts_before_guest_standby` - (Optional) Enable pre-standby scripts to run when VMware Tools is installed. Default: `true`.

* `sync_time_with_host` - (Optional) Enable the guest operating system to synchronization its clock with the host when the virtual machine is powered on or resumed. Requires vSphere 7.0 Update 1 and later. Requires VMware Tools to be installed. Default: `false`.
* `sync_time_with_host` - (Optional) Enable the guest operating system to synchronization its clock with the host when the virtual machine is powered on or resumed. Requires vSphere 7.0 Update 1 and later. Requires VMware Tools to be installed. Default: `true`.

* `sync_time_with_host_periodically` - (Optional) Enable the guest operating system to periodically synchronize its clock with the host. Requires vSphere 7.0 Update 1 and later. On previous versions, setting `sync_time_with_host` is will enable periodic synchronization. Requires VMware Tools to be installed. Default: `false`.

Expand Down