-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Feat] Allow custom naming of vLLM processes #21445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a feature to allow custom naming of vLLM processes via the VLLM_PROCESS_NAME_PREFIX
environment variable, which is useful for monitoring. The implementation uses the setproctitle
library across different vLLM components. My main concern is that setproctitle
is a new dependency that needs to be added to the project's dependency files to avoid runtime errors.
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
/cc @DarkLight1337 @njhill @ciaoyizhen PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chaunceyjiang I wasn't aware it was so easy to do this!
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't believe it, it turned out even better than I expected.
Please fix doc build |
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@DarkLight1337 Done. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given tests pass
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Supports #21423
Purpose
Test Result
CUDA:
TP=4
DP=2
TP=2. DP=2
Note: The process
python3.12 -c from multiprocessing.resource_tracker import main;main(36)
is automatically generated when usingfrom multiprocessing import shared_memory
, so there is currently no way to modify its process name.Keep the process name consistent with the naming style of SGlang processes.